Re: [PATCH] arm/dt: tegra devicetree support
From: Grant Likely
Date: Wed Jul 20 2011 - 14:45:27 EST
On Wed, Jul 20, 2011 at 11:33:56AM -0700, Stephen Warren wrote:
> Grant Likely wrote at Wednesday, July 20, 2011 12:28 PM:
> > On Wed, Jul 20, 2011 at 08:37:19AM -0700, Stephen Warren wrote:
> > > Grant Likely wrote at Tuesday, July 19, 2011 5:43 PM:
> > > > Everything required to populate NVIDIA Tegra devices from the device
> > > > tree. This patch adds a new DT_MACHINE_DESC() which matches against
> > > > a tegra20 device tree. So far it only registers the on-chip devices,
> > > > but it will be refined in follow on patches to configure clocks and
> > > > pin IO from the device tree also.
> > > > diff --git a/arch/arm/boot/dts/tegra-harmony.dts b/arch/arm/boot/dts/tegra-harmony.dts
> > >
> > > tegra-*.dts don't include status="disable" for all the unused controllers.
> > > Should that be added?
> > I dropped that pattern since my preference has been to have boards
> > explicitly disable unused cores and that has generally been the
> > pattern on other DT platforms.
> Sorry if I wasn't clear, but what I meant was that the board-specific
> files tegra-harmony.dts and tegra-seaboard.dts don't include the status=
> "disable" entries for the modules/ports they don't use.
> Still, everything probably works OK without that...
For eval platforms, unless it is actively dangerous I would leave
devices enabled. If it is actively dangerous (or potentially so) then
that is an argument to disable by default in the tegra20.dtsi file,
but I've not yet run into any situations like that.
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/