Re: [PATCH] arm/dt: tegra devicetree support

[Mark Brown]

On Wed, Jul 20, 2011 at 08:37:19AM -0700, Stephen Warren wrote:
> Grant Likely wrote at Tuesday, July 19, 2011 5:43 PM:

> > +	sound {
> > +		compatible = "nvidia,harmony-sound", "nvidia,tegra-wm8903";

> I thought the sound bindings were still somewhat experimental and not
> completely agreed upon. One issue I see is that Device Tree is
> supposed to represent pure HW, rather than driver-required abstractions,
> and at least the compatible name here is pretty Linux-driver-specific.

The current decision is that the schematic for embedded audio hardware
is sufficiently interesting to be considered hardware in its own right
separately to the chips contained within it.  

> > +		spkr-en-gpios = <&codec 2 0>;

> Should that be "gpio" not "gpios", since there is only one?

There's only one in this board but one does see designs with separate
left and right channel enables sometimes, or separate front and back
speaker enables for phones.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/