Re: [PATCH v4 3.0-rc2-tip 7/22] 7: uprobes: mmap and fork hooks.

From: Peter Zijlstra
Date: Wed Jul 20 2011 - 07:57:12 EST


On Tue, 2011-07-19 at 12:23 +0530, Srikar Dronamraju wrote:
> > I don't think you can sell this, that'll make munmap() horridly slow.
>
> Okay,
>
> How about using a counter and a wq in each vma.
> Based on the counter, I can wait in the munmap() and since this is per
> vma, this should be faster than srcu.
>
> Counter would be incremented when we do a vma-rmap walk.
> decremented when after insertion/deletion.
> read in munmap().

I know I would feel somewhat uneasy about growing struct vm_area_struct
for just uprobes, but what do other people think?

Andrew, Christoph?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/