RE: [PATCH 1/3] usb: tegra20-ehci: Add devicetree support.

From: Stephen Warren
Date: Tue Jul 19 2011 - 18:56:42 EST


achew@xxxxxxxxxx wrote at Tuesday, July 19, 2011 4:47 PM:
> From: Andrew Chew <achew@xxxxxxxxxx>
>
> Add code to try to get platform data information (register base, irq,
> modes, various tuning parameters) from device tree, if not present in board
> files.
>
> Signed-off-by: Andrew Chew <achew@xxxxxxxxxx>
> ---
> .../devicetree/bindings/usb/tegra20-ehci.txt | 27 +++
> arch/arm/mach-tegra/include/mach/usb_phy.h | 2 +-
> drivers/usb/host/ehci-tegra.c | 197 +++++++++++++++++++-
> 3 files changed, 219 insertions(+), 7 deletions(-)
> create mode 100644 Documentation/devicetree/bindings/usb/tegra20-ehci.txt

I sent a variety of comments on this patch internally to Andrew, but the
email crossed paths with the posting to the public mailing lists. I won't
bother repeating those comments here, but I assume they'll be addressed
in a new version of this patch.

--
nvpublic

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/