Re: [RFC][PATCH -mmotm 0/4] Improvement of pstore/kmsg_dump inkexec/panic path

From: Vivek Goyal
Date: Tue Jul 19 2011 - 14:48:22 EST

On Tue, Jul 19, 2011 at 02:23:26PM -0400, Seiji Aguchi wrote:
> Hi,
> [Upstream status]
> Discussion about kmsg_dump() in kdump path:
> - Eric and Vivek are worried about reliability of existing kmsg_dump().
> - Especially, Vivek would like to remove a RCU function call chain in kdump path
> ããã which kernel modules can register their function calls freely.
> Discussion about pstore in nmi_hander.
> - Don Zickus found an issue of pstore in nmi_handler due to its mutex_lock.

You did not answer my questions in the last posting mail thread and gone
ahead with the new posting. How are we supposed to discuss something. This
has been a problem on this mail thread since the beginneing. There is
little open discussion.

So if you want to make any progress in this direction, what will help
is open discussion.

Locking is going to be a problem. So atleast we can remove kmsg_dump()
infrastructure from reboot path. Why can't we log something in user
space when user initiates a reboot, let it get logged in /var/log/messages
and then umount the file root and go ahead with reboot. Why does kernel
need to capture that info in NVRAM.

If we can get rid of all the logging thing on reboot path, then at least
it does not need to be lock protected with crash path.

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at