Re: [PATCH] writeback: Don't wait for completion inwriteback_inodes_sb_nr
From: Christoph Hellwig
Date: Tue Jul 19 2011 - 12:56:47 EST
On Fri, Jul 15, 2011 at 01:08:54AM +0200, Jan Kara wrote:
> Actually, it's the other way around writeback_inodes_sb() is superfluous
> because of wakeup_flusher_threads(). So something like attached patch could
> improve sync times (especially in presence of other IO). So far I have only
> checked that sync times look reasonable with it but didn't really compare
> them with original kernel...
This changes the order in which ->quota_sync is called relatively to
other operations, see my other mail about it. Also the code gets really
confusing at this point, I think you're better of stopping to try to
shared code between syncfs, umount & co and sys_sync with these bits.
You're also skipping the ->sync_fs and quotasync calls the first round.
I know for XFS sync_fs without wait is already mostly a no-op, but we'll
need to benchmark and document this change, and apply it to the non-sync
caller as well.
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/