Re: [PATCH 1/2] serial:blackfin: Correct coding style in bfinserial driver.

From: Joe Perches
Date: Tue Jul 19 2011 - 11:28:42 EST


On Tue, 2011-07-19 at 18:09 +0800, Sonic Zhang wrote:
> From: Sonic Zhang <sonic.zhang@xxxxxxxxxx>
[]
> @@ -1091,10 +1090,18 @@ bfin_serial_console_get_options(struct bfin_serial_port *uart, int *baud,
> *parity = 'o';
> }
> switch (lcr & 0x03) {
> - case 0: *bits = 5; break;
> - case 1: *bits = 6; break;
> - case 2: *bits = 7; break;
> - case 3: *bits = 8; break;
> + case 0:
> + *bits = 5;
> + break;
> + case 1:
> + *bits = 6;
> + break;
> + case 2:
> + *bits = 7;
> + break;
> + case 3:
> + *bits = 8;
> + break;
> }

Maybe just:
*bits = 5 + (lcr & 3);

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/