RE: [PATCH] davinci: fix DM365 EVM video input mux bits

From: Hadli, Manjunath
Date: Tue Jul 19 2011 - 03:25:33 EST


Will not be able to give you a sub-patch as it is combined as part of a larger implementation.

Since the bug fix needs to go into 3.0, I am Ok if you fix the bug, and the macros can be substituted later.

-Manju

On Tue, Jul 19, 2011 at 11:58:19, Jon Povey wrote:
> Hadli, Manjunath wrote:
> > Jon,
> >
> > The fix looks correct. As a part of a different implementation which
> > will go soon upstream, this has been taken care of, where we have used
> > macros
> > CPLD_VIDEO_INPUT_MUX_TVP7002 0x1
> > CPLD_VIDEO_INPUT_MUX_IMAGER 0x2
> >
> > So, if you can do the same, it will look better.
>
> If you have a patch you can split out that has your defines where and how you want them then great.
>
> Otherwise I'd suggest just getting this or something equivalent in to fix the bug first, and reimplement it later.
>
> --
> Jon Povey
> jon.povey@xxxxxxxxxxxxxxx
>
> Racelogic is a limited company registered in England. Registered number 2743719 .
> Registered Office Unit 10, Swan Business Centre, Osier Way, Buckingham, Bucks, MK18 1TB .
>
> The information contained in this electronic mail transmission is intended by Racelogic Ltd for the use of the named individual or entity to which it is directed and may contain information that is confidential or privileged. If you have received this electronic mail transmission in error, please delete it from your system without copying or forwarding it, and notify the sender of the error by reply email so that the sender's address records can be corrected. The views expressed by the sender of this communication do not necessarily represent those of Racelogic Ltd. Please note that Racelogic reserves the right to monitor e-mail communications passing through its network
>
>
>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/