Re: [PATCH 1/2 v3] Staging: comedi: fix printk() issue in adv_pci1710.c

From: Ryan Mallon
Date: Tue Jul 19 2011 - 02:16:01 EST

On 19/07/11 16:12, Dan Carpenter wrote:
On Tue, Jul 19, 2011 at 04:07:27PM +1000, Ryan Mallon wrote:
This still isn't correct. The initial printk (KERN_INFO above) has
no trailing newline. Here you are almost doing it correctly, except
that you are adding an extra newline. This error message will look
like this:

comedi0: adv_pci1710:
comedi0: adv_pci1710: Allocation failed

Actually kmalloc() prints an message with a stack trace on failure as
well so that would go in the middle, just before the first newline.

Thanks. Didn't know that. Is that a KConfig option or by default?

Either way, it's another good reason to get rid of all the KERN_CONT stuff in the driver.

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at