Re: [PATCH 4/9] pstore: Allow the user to explicitly choose a backend

From: Tony Luck
Date: Mon Jul 18 2011 - 17:08:26 EST


On Mon, Jul 18, 2011 at 2:00 PM, Matthew Garrett <mjg59@xxxxxxxxxxxxx> wrote:
> On Mon, Jul 18, 2011 at 01:58:28PM -0700, Tony Luck wrote:

>> We don't allow backends to be unregistered (currently) - Do you think it would
>> be helpful to mention in this text that you cannot change your mind and
>> switch to a different back end once you have registered one? Writing
>> to /sys/module/... sounds a lot more flexible than what reality will allow.
>
> Mm. Yes, the lack of unregistration does make that less helpful. Perhaps
> best to make that unwritable.

Perhaps .... writable would be useful in this sequence:

1) Load pstore (or pstore is built in)
2) write to /sys/module/pstore/parameters/backend to chose backend
3) load other modules (including multiple pstore backends)

But that seems rather contrived - a user doing this could just adjust step 3
to only load the preferred backend (or make sure the preferred one goes first).

-Tony
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/