Re: [Patch] mm: make CONFIG_NUMA depend on CONFIG_SYSFS

[Randy Dunlap]

On Mon, 18 Jul 2011 19:09:50 +0200 Andi Kleen wrote:

> On Mon, Jul 18, 2011 at 03:14:18PM +0300, Pekka Enberg wrote:
> > On Mon, Jul 18, 2011 at 2:18 PM, Amerigo Wang <amwang@xxxxxxxxxx> wrote:
> > > On ppc, we got this build error with randconfig:
> > >
> > > drivers/built-in.o:(.toc1+0xf90): undefined reference to `vmstat_text': 1 errors in 1 logs
> > >
> > > This is due to that it enabled CONFIG_NUMA but not CONFIG_SYSFS.
> > >
> > > And the user-space tool numactl depends on sysfs files too.
> > > So, I think it is very reasonable to make CONFIG_NUMA depend on CONFIG_SYSFS.
> > 
> > Is it? CONFIG_NUMA is useful even without userspace numactl tool, no?
> 
> Yes it is. No direct dependency.
> 
> I would rather fix it in ppc.

This isn't a ppc-only error.  It happens when CONFIG_PROC_FS is not enabled
(or is it CONFIG_SYSFS?).

I reported it for linux-next of 20110526:

when CONFIG_PROC_FS is not enabled:

drivers/built-in.o: In function `node_read_vmstat':
node.c:(.text+0x56ffa): undefined reference to `vmstat_text'


---
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/