Re: [PATCH] USB: xhci: fix OS want to own HC

From: Sarah Sharp
Date: Mon Jul 18 2011 - 12:44:27 EST


On Sat, Jul 16, 2011 at 11:04:19AM +0800, JiSheng Zhang wrote:
> Software should set XHCI_HC_OS_OWNED bit to request ownership of xHC

Good catch! I'll queue this up to my for-usb-linus branch and send it
out to Greg later today.

Greg, do you think it's too late to get this into 3.0? Shall I just
add it to usb-next and mark it for stable?

Sarah Sharp

> Signed-off-by: JiSheng Zhang <jszhang3@xxxxxxxxx>
> ---
> drivers/usb/host/pci-quirks.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/usb/host/pci-quirks.c b/drivers/usb/host/pci-quirks.c
> index fd93061..1a73004 100644
> --- a/drivers/usb/host/pci-quirks.c
> +++ b/drivers/usb/host/pci-quirks.c
> @@ -775,7 +775,7 @@ static void __devinit quirk_usb_handoff_xhci(struct pci_dev *pdev)
>
> /* If the BIOS owns the HC, signal that the OS wants it, and wait */
> if (val & XHCI_HC_BIOS_OWNED) {
> - writel(val & XHCI_HC_OS_OWNED, base + ext_cap_offset);
> + writel(val | XHCI_HC_OS_OWNED, base + ext_cap_offset);
>
> /* Wait for 5 seconds with 10 microsecond polling interval */
> timeout = handshake(base + ext_cap_offset, XHCI_HC_BIOS_OWNED,
> --
> 1.7.5.4
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/