Re: [PATCH 30/30 v2] Staging: comedi: fix printk() issue indas16m1.c

From: Joe Perches
Date: Mon Jul 18 2011 - 11:46:32 EST

On Mon, 2011-07-18 at 11:43 +0200, Jesper Juhl wrote:
> On Mon, 18 Jul 2011, Ravishankar wrote:
> > - printk(" io 0x%lx-0x%lx 0x%lx-0x%lx",
> > + printk(KERN_INFO " requesing the I/O region from 0x%lx-0x%lx 0x%lx-0x%lx",
> Correct spelling is "requesting" and the "from" should either have a
> matching "to" or just be dropped IMHO.
> Personally I'd just make it:
> " requesting I/O region 0x%lx-0x%lx 0x%lx-0x%lx"
> I think the original text was better.

KERN_INFO is the wrong level.

Just log the errors at KERN_ERR/pr_err and make the rest
pr_debug or delete them.

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at