problem with function vlan_get_protocol()

From: jiangtao.jit
Date: Sat Jul 16 2011 - 23:52:29 EST


Hi,all

in file inclue/linux/if_vlan.h

there is a statement in function vlan_get_protocol()

if (likely(protop))
protocol = *protop;

do we need an else branch on pointer protop failed through the else is unlikely

if (likely(protop))
protocol = *protop;
else
protocol = proto;

thanks

----------------------
2011-07-17
jiangtao.jit

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/