Re: [PATCH] [RFC] perf: robustify proc and debugfs file recording

[Sonny Rao]

On Wed, Jul 13, 2011 at 3:52 AM, Michael Neuling <mikey@xxxxxxxxxxx> wrote:
> In message <29926.1310553581@xxxxxxxxxxx> you wrote:
>> Sonny,
>>
>>
>> > While attempting to create a timechart of boot up I found
>> > perf didn't tolerate modules being loaded/unloaded.  This patch
>> > fixes this by reading the file once and then writing the size
>> > read at the correct point in the file.  It also simplifies the
>> > code somewhat.
>>
>> I'm getting a bunch of unused variables warnings when I compile this.
>> Care to clean them up?
>>
>>     CC util/trace-event-info.o
>> util/trace-event-info.c: In function =E2=80=98read_header_files=E2=80=99:
>> util/trace-event-info.c:221:27: error: unused variable =E2=80=98check_size=
>> =E2=80=99 [-Werror=3Dunused-variable]
>> util/trace-event-info.c:221:21: error: unused variable =E2=80=98size=E2=80=
>> =99 [-Werror=3Dunused-variable]
>> util/trace-event-info.c: In function =E2=80=98copy_event_system=E2=80=99:
>> util/trace-event-info.c:255:27: error: unused variable =E2=80=98check_size=
>> =E2=80=99 [-Werror=3Dunused-variable]
>> util/trace-event-info.c:255:21: error: unused variable =E2=80=98size=E2=80=
>> =99 [-Werror=3Dunused-variable]
>> util/trace-event-info.c: In function =E2=80=98read_proc_kallsyms=E2=80=99:
>> util/trace-event-info.c:377:21: error: unused variable =E2=80=98check_size=
>> =E2=80=99 [-Werror=3Dunused-variable]
>> util/trace-event-info.c: In function =E2=80=98read_ftrace_printk=E2=80=99:
>> util/trace-event-info.c:394:21: error: unused variable =E2=80=98check_size=
>> =E2=80=99 [-Werror=3Dunused-variable]
>> cc1: all warnings being treated as errors
>
> Actually, here's an updated patch to fix these..
>
> FYI perf record/annotate/report works fine on my powerpc box here with
> this.  I don't have modules handy so I've not tested that aspect.
>
> Mikey

Thanks for the testing and the cleanup!  You don't really need to test
the modules thing
I just wanted to make sure it worked period on big-endian.

Sonny
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/