Re: [PATCH] Avoid Wunused-but-set warning

From: Pekka Enberg
Date: Wed Jul 13 2011 - 08:16:53 EST


On Wed, Jul 13, 2011 at 5:21 AM, Arnaud Lacombe <lacombar@xxxxxxxxx> wrote:
> I have the feeling from this thread that "Acked-by:" does not need any
> particular qualification, whereas Reviewed-by: "kinda" does. But I may
> have understood that all wrong. Btw, I say "kinda" as I see nothing in
> the Reviewed-by: or Acked-by: definition that require any
> qualification on the involved subsystem to give an Acked-by: or a
> Reviewed-by:. Maybe we [not?] need such some formal requirement.

The formal requirement for 'Reviewed-by' is that you're OK with Linus
and the gang handing your ass to you on a plate when a patch you've
blessed with your tag breaks the world. 'Acked-by' is similar in
nature but the repercussions are less severe.

Pekka
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/