Re: [PATCH] modpost: Fix modpost's license checking V2

From: Arnaud Lacombe
Date: Tue Jul 12 2011 - 14:49:47 EST


Hi,

On Tue, Jul 12, 2011 at 2:35 PM, Anders Kaseorg <andersk@xxxxxxxxxxx> wrote:
> On Tue, Jul 12, 2011 at 14:15, Arnaud Lacombe <lacombar@xxxxxxxxx> wrote:
>> modpost is an host tool, it should not include kernel header. Content
>> of this file is not exported to userland anyway.
>
> My point was more that you might as well reuse the same name and
> probably the same code so that people don’t have to look carefully at
> a new macro to decide whether it’s off-by-one from what they expect.
>
Agree. I was not entirely sure of what you meant, ie. whether
including "include/linux/string.h" or adjusting the name and
definition to match the existing. So I thought it would just be better
to clear any potential misunderstanding :)

- Arnaud
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/