Re: [PATCH v2] acpi: introduce "acpi_rsdp=" parameter for kdump

From: Konrad Rzeszutek Wilk
Date: Tue Jul 12 2011 - 09:31:46 EST


On Tue, Jul 12, 2011 at 06:30:18PM +0800, Cong Wang wrote:
> ä 2011å07æ11æ 23:14, Takao Indoh åé:
> >Revised version of the patch which was posted by Cong WANG
> >
> >Changes in v2:
> >* Change parameter name from "acpi_addr" to "acpi_rsdp"
> >* Add CONFIG_KEXEC
>
> Thanks for updating it! Definitely looks good to me,

The only comment I've is that it would be good to include in the
patch description which sysfs attribute is used by the kexec tools
to read in the physical address to be passed in.

Otherwise it looks good to me too.
>
> Reviewed-by: WANG Cong <amwang@xxxxxxxxxx>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/