Re: [PATCH 1/2] arch: arm: Correct the dependency of HAVE_ARM_TWD

From: Russell King - ARM Linux
Date: Tue Jul 12 2011 - 03:34:18 EST


On Tue, Jul 12, 2011 at 02:57:38PM +0800, æåæ wrote:
> 2011/7/8 Russell King - ARM Linux <linux@xxxxxxxxxxxxxxxx>
> >
> > On Fri, Jul 08, 2011 at 01:10:14PM +0400, Anton Vorontsov wrote:
> > > On Fri, Jul 08, 2011 at 01:59:23PM +0800, Tommy Lin wrote:
> > > Russell,
> > >
> > > As the patch is needed for CNS3xxx Watchdog support, I'd like to take
> > > it via CNS3xxx tree, if you're OK with that.
> >
> > No.
> >
> > TWD is only useful if SMP is enabled, otherwise the contained code
> > won't be called. Without SMP you'll find that the timer rate will
> > be zero.
> >
> > So actually your problems are bigger than just this dependency.
>
> I think LOCAL_TIMERS is the one that useful if SMP is enabled. The zero
> timer rate issue still able to limited by LOCAL_TIMERS.

No. I could repeat everything I've said about the initialization but
there's no point. I'm not dropping the SMP dependency of SMP_TWD.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/