Re: [PATCH 21/21] dynamic_debug: delete pending queries

From: Joe Perches
Date: Mon Jul 11 2011 - 20:25:41 EST


On Mon, 2011-07-11 at 01:46 -0600, Jim Cromie wrote:
> delete pending queries by re-issuing it with disabled flags
[]
> diff --git a/lib/dynamic_debug.c b/lib/dynamic_debug.c
[]
> @@ -505,7 +505,17 @@ static int ddebug_save_pending(struct ddebug_query *query,
>
> list_for_each_entry_safe(pq, pqnext, &pending_queries, link) {
> if (queries_match(query, &pq->query)) {
> - /* query already in list, update flags */
> + /* query already in list */
> + if (!flags) {
> + /* zeroed flags, remove query */
> + if (verbose)
> + pr_info("delete pending: %s\n",
> + show_pending_query(pq));

I think these should be pr_debug.
I know you're only using the current style.

Jason, any reason these can not be converted?

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/