Re: [PATCH 2/3] iwlegacy: Add missing comma between constant stringarray

From: John W. Linville
Date: Mon Jul 11 2011 - 14:47:26 EST


How is this array indexed? Aren't you changing the index of the
later strings?

On Fri, Jul 08, 2011 at 11:20:24PM -0700, Joe Perches wrote:
> Multiple quoted strings are concatenated without comma separators.
>
> Signed-off-by: Joe Perches <joe@xxxxxxxxxxx>
> ---
> drivers/net/wireless/iwlegacy/iwl4965-base.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/net/wireless/iwlegacy/iwl4965-base.c b/drivers/net/wireless/iwlegacy/iwl4965-base.c
> index 46242d2..1433466 100644
> --- a/drivers/net/wireless/iwlegacy/iwl4965-base.c
> +++ b/drivers/net/wireless/iwlegacy/iwl4965-base.c
> @@ -1484,7 +1484,7 @@ static const char * const desc_lookup_text[] = {
> "NMI_INTERRUPT_DATA_ACTION_PT",
> "NMI_TRM_HW_ER",
> "NMI_INTERRUPT_TRM",
> - "NMI_INTERRUPT_BREAK_POINT"
> + "NMI_INTERRUPT_BREAK_POINT",
> "DEBUG_0",
> "DEBUG_1",
> "DEBUG_2",
> --
> 1.7.6.131.g99019
>
>

--
John W. Linville Someday the world will need a hero, and you
linville@xxxxxxxxxxxxx might be all we have. Be ready.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/