Re: [PATCH 10/10] Staging: comedi: fix brace printk() issue inpcl818.c

From: Tobias Klauser
Date: Mon Jul 11 2011 - 04:21:06 EST


On 2011-07-11 at 09:51:52 +0200, Ravishankar <ravishankarkm32@xxxxxxxxx> wrote:
> From: Ravishankar <ravi.shankar@xxxxxxxxxxxxxxx>
>
> This is a patch to the pcl818.c file that fixes up a printk() warning found by the checkpatch.pl tool
>
> Signed-off-by: Ravishankar <ravishankarkm32@xxxxxxxxx>
> ---
> drivers/staging/comedi/drivers/pcl818.c | 8 ++++----
> 1 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/staging/comedi/drivers/pcl818.c b/drivers/staging/comedi/drivers/pcl818.c
> index 2fdb8c9..4069fee 100644
> --- a/drivers/staging/comedi/drivers/pcl818.c
> +++ b/drivers/staging/comedi/drivers/pcl818.c
> @@ -1777,7 +1777,7 @@ static int pcl818_attach(struct comedi_device *dev, struct comedi_devconfig *it)
> irq);
> irq = 0; /* Can't use IRQ */
> } else {
> - printk(", irq=%u", irq);
> + printk(KERN_INFO ", irq=%u", irq);

This should be KERN_CONT.

> }
> }
> }
> @@ -1883,7 +1883,7 @@ no_dma:
> if (check_single_ended(dev->iobase)) {
> s->n_chan = this_board->n_aichan_se;
> s->subdev_flags |= SDF_COMMON | SDF_GROUND;
> - printk(", %dchans S.E. DAC", s->n_chan);
> + printk(KERN_INFO ", %dchans S.E. DAC", s->n_chan);

Ditto.

> } else {
> s->n_chan = this_board->n_aichan_diff;
> s->subdev_flags |= SDF_DIFF;
> --
> 1.6.5.2
>
> _______________________________________________
> devel mailing list
> devel@xxxxxxxxxxxxxxxxxxxxxx
> http://driverdev.linuxdriverproject.org/mailman/listinfo/devel
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/