Re: [PATCH] x86: do_signal: simplify the TS_RESTORE_SIGMASK logic

[Al Viro]

On Sun, Jul 10, 2011 at 08:22:03PM +0200, Oleg Nesterov wrote:

> 2. do_signal() also clears TS_RESTORE_SIGMASK if handle_signal()
>    succeeds.
> 
>    We can move this to setup_rt_frame() as well, this avoids the
>    unnecessary checks and makes the logic more clear.


> +	current_thread_info()->status &= ~TS_RESTORE_SIGMASK;
>  	return ret;

This is broken.  If setup_rt_frame() fails, you don't want to do that.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/