Re: state machine defect in drivers/tty/vt/vt.c?

[Andreas Schwab]

Joe Perches <joe@xxxxxxxxxxx> writes:

> vc->vc_state is sequentially set to different values.
>
> Looks like there's either a return or a break
> missing at the end of case ESgetpars:
>
> Anyone know the right fix here?

The first assignment can be removed.

> 	case ESgetpars:
> 		if (c == ';' && vc->vc_npar < NPAR - 1) {
> 			vc->vc_npar++;
> 			return;
> 		} else if (c>='0' && c<='9') {
> 			vc->vc_par[vc->vc_npar] *= 10;
> 			vc->vc_par[vc->vc_npar] += c - '0';
> 			return;
> 		} else
> 			vc->vc_state = ESgotpars;
> 	case ESgotpars:
> 		vc->vc_state = ESnormal;

That handles cases like '\033[m' where '\033[' enters state ESgetpars,
but 'm' is handled by ESgotpars.

Andreas.

-- 
Andreas Schwab, schwab@xxxxxxxxxxxxxx
GPG Key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/