Re: [PATCH] ARM: gic: Allow gic arch extensions to provide irqchip flags

[Colin Cross]

On Sat, Jul 9, 2011 at 5:03 PM, Santosh Shilimkar
<santosh.shilimkar@xxxxxx> wrote:
> On 6/12/2011 5:45 PM, Colin Cross wrote:
>>
>> Tegra can benefit from the IRQCHIP_MASK_ON_SUSPEND flag, allow it
>> to be passed to the gic irq chip.
>>
>> Signed-off-by: Colin Cross<ccross@xxxxxxxxxxx>
>
> I missed this patch. Looks good to me and I think can
> be merged in rc as well.
> Acked-by: Santosh Shilimkar <santosh.shilimkar@xxxxxx>

There is no need for this in an rc unless another patch destined for
rc needs to set the flags, which is unlikely at this point.

>> ---
>>  arch/arm/common/gic.c |    1 +
>>  1 files changed, 1 insertions(+), 0 deletions(-)
>>
>> diff --git a/arch/arm/common/gic.c b/arch/arm/common/gic.c
>> index 8d62e07..a6c28a0 100644
>> --- a/arch/arm/common/gic.c
>> +++ b/arch/arm/common/gic.c
>> @@ -576,6 +576,7 @@ void __init gic_init(unsigned int gic_nr, unsigned int
>> irq_start,
>>        if (gic_nr == 0)
>>                gic_cpu_base_addr = cpu_base;
>>
>> +       gic_chip.flags |= gic_arch_extn.flags;
>>        gic_dist_init(gic, irq_start);
>>        gic_cpu_init(gic);
>>        gic_cpu_pm_init(gic);
>
> Russell,
> Any thoughts on this fix?
>
> Regards
> Santosh
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/