Re: [PATCH] x86: enable rtc-efi

From: Matthew Garrett
Date: Fri Jul 08 2011 - 03:10:21 EST


On Fri, Jul 08, 2011 at 07:46:35AM +0100, Jan Beulich wrote:

> Having thought some more about this, I don't think this should be
> handled in the RTC driver. Instead, arch/x86/platform/efi/efi.c ought
> to be handling this - also for all other eventual callers of the time
> related calls. In other words, the bug has been existing before my
> patch (and it just exposes it by introducing callers of the incompletely
> implemented backing functions).

I'm in the process of removing this code from arch/x86, since it's
functionally identical to the IA64 version. That's probably going to
complicate this approach a little, but you're right that it makes sense
for the locking to be at the backend rather than in rtc-efi.

--
Matthew Garrett | mjg59@xxxxxxxxxxxxx
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/