Re: gma500: Mask out bits not part of the page table base address

From: Alan Cox
Date: Thu Jul 07 2011 - 18:12:45 EST


On Fri, 8 Jul 2011 00:06:21 +0200
Patrik Jakobsson <patrik.r.jakobsson@xxxxxxxxx> wrote:

> Otherwise we can't ioremap the gtt and the screen gets garbled.
>
> Signed-off-by: Patrik Jakobsson <patrik.r.jakobsson@xxxxxxxxx>
> ---
>
> diff --git a/drivers/staging/gma500/gtt.c b/drivers/staging/gma500/gtt.c
> index 28f2261..78dd01b 100644
> --- a/drivers/staging/gma500/gtt.c
> +++ b/drivers/staging/gma500/gtt.c
> @@ -397,7 +397,7 @@ int psb_gtt_init(struct drm_device *dev, int resume)
> /* The root resource we allocate address space from */
> dev_priv->gtt_initialized = 1;
>
> - pg->gtt_phys_start = dev_priv->pge_ctl;
> + pg->gtt_phys_start = dev_priv->pge_ctl & PAGE_MASK;

Umm yes I suppose if its already been enabled that'll be slightly
important

Acked-by: Alan Cox <alan@xxxxxxxxxxxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/