Re: [PATCH 02/10] dynamic_debug: Consolidate prefix output to single routine

[Bart Van Assche]

On Wed, Jul 6, 2011 at 7:24 PM, Jason Baron <jbaron@xxxxxxxxxx> wrote:
>
> From: Joe Perches <joe@xxxxxxxxxxx>
>
> Adding dynamic_dev_dbg duplicated prefix output.
> Consolidate that output to a single routine.
>
> Signed-off-by: Joe Perches <joe@xxxxxxxxxxx>
> Signed-off-by: Jason Baron <jbaron@xxxxxxxxxx>
> ---
>  lib/dynamic_debug.c |   38 ++++++++++++++++++--------------------
>  1 files changed, 18 insertions(+), 20 deletions(-)
>
> diff --git a/lib/dynamic_debug.c b/lib/dynamic_debug.c
> index 5c5f8f9..758e922 100644
> --- a/lib/dynamic_debug.c
> +++ b/lib/dynamic_debug.c
> @@ -428,15 +428,10 @@ static int ddebug_exec_query(char *query_string)
>        return 0;
>  }
>
> -int __dynamic_pr_debug(struct _ddebug *descriptor, const char *fmt, ...)
> +static int dynamic_emit_prefix(const struct _ddebug *descriptor)
>  {

How about renaming dynamic_emit_prefix() into ddebug_emit_prefix() ?
Personally I prefer the latter name over the former.

Bart.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/