Re: [PATCH 2/2] dmaengine: remove ste_dma40 from issue_pending TODO

From: Linus Walleij
Date: Thu Jul 07 2011 - 10:27:53 EST


2011/7/7 Vinod Koul <vkoul@xxxxxxxxxxxxx>:
> On Sun, 2011-06-26 at 23:29 +0200, Per Forlin wrote:
>> ste_dma40 now implements issue_pending according to documentation.
>> Submit adds descriptos to a pending queue with are flushed down to the DMAC
>> at issue_pending.
>>
>> Signed-off-by: Per Forlin <per.forlin@xxxxxxxxxx>
> How about the client driver which are currently using this driver, wont
> they break as they would be calling submit and not issue_pending...?

They all call both, so it works fine. First submit() then issue_pending()
in sucession.

In-tree drivers:
drivers/tty/serial/amba-pl011.c
drivers/mmc/host/mmci.c
drivers/spi/spi-pl022.c

So:
Acked-by: Linus Walleij <linus.walleij@xxxxxxxxxx>

Thanks,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/