Re: [PATCH v3 1/3] driver core: Add ability for arch code to setuppdev_archdata

[Greg KH]

On Thu, Jul 07, 2011 at 08:55:44AM -0500, Kumar Gala wrote:
> 
> On Jul 1, 2011, at 5:09 PM, Greg KH wrote:
> 
> > On Thu, Jun 23, 2011 at 06:33:57AM -0500, Kumar Gala wrote:
> >> On some architectures we need to setup pdev_archdata before we add the
> >> device.  Waiting til a bus_notifier is too late since we might need the
> >> pdev_archdata in the bus notifier.  One example is setting up of dma_mask
> >> pointers such that it can be used in a bus_notifier.
> >> 
> >> We add noop version of arch_setup_pdev_archdata() in
> >> <asm-generic/platform_device.h> and allow the arch code to override with
> >> access the full definitions of struct device, struct platform_device, and
> >> struct pdev_archdata.
> > 
> > Isn't there some way to use "weak" symbols to keep us from having to
> > create this .h file in every single arch and then if the arch wants to
> > define it, it does so?
> > 
> > That should make this patch simpler, right?
> > 
> > thanks,
> > 
> > greg k-h
> 
> Changing to weak should be doable if we are ok with the additional
> function call always happening.

Given that this is not a fast path, and the function call for the
"normal" case would do nothing, it should be fine, right?

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/