Re: [PATCH] fs: fix lock initialization

[Matthew Wilcox]

On Wed, Jul 06, 2011 at 10:40:44AM -0700, Linus Torvalds wrote:
> Ugh. Code that depends on SLAB initializers is broken.
> 
> The reason for those initializers are traditionally "better cache
> behavior" where you don't need to initialize everything at allocation
> time, but the whole concept is almost invariably a disaster. This is a
> prime example of it.

It'd be good to have that documented somewhere.  When I wrote this code
(a decade ago), that wasn't my understanding.

-- 
Matthew Wilcox				Intel Open Source Technology Centre
"Bill, look, we understand that you're interested in selling us this
operating system, but compare it to ours.  We can't possibly take such
a retrograde step."
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/