[PATCH] futex: uninitialized warning corrections

From: Vitaliy Ivanov
Date: Wed Jul 06 2011 - 17:05:05 EST


kernel/futex.c: In function âfixup_pi_state_owner.clone.17â:
kernel/futex.c:1582:6: warning: âcurvalâ may be used uninitialized in this function
kernel/futex.c: In function âhandle_futex_deathâ:
kernel/futex.c:2486:6: warning: ânvalâ may be used uninitialized in this function
kernel/futex.c: In function âdo_futexâ:
kernel/futex.c:863:11: warning: âcurvalâ may be used uninitialized in this function
kernel/futex.c:828:6: note: âcurvalâ was declared here
kernel/futex.c:898:5: warning: âoldvalâ may be used uninitialized in this function
kernel/futex.c:890:6: note: âoldvalâ was declared here

Signed-off-by: Vitaliy Ivanov <vitalivanov@xxxxxxxxx>
---
kernel/futex.c | 8 ++++----
1 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/kernel/futex.c b/kernel/futex.c
index fe28dc2..efb8e5b 100644
--- a/kernel/futex.c
+++ b/kernel/futex.c
@@ -825,7 +825,7 @@ static int wake_futex_pi(u32 __user *uaddr, u32 uval, struct futex_q *this)
{
struct task_struct *new_owner;
struct futex_pi_state *pi_state = this->pi_state;
- u32 curval, newval;
+ u32 uninitialized_var(curval), newval;

if (!pi_state)
return -EINVAL;
@@ -887,7 +887,7 @@ static int wake_futex_pi(u32 __user *uaddr, u32 uval, struct futex_q *this)

static int unlock_futex_pi(u32 __user *uaddr, u32 uval)
{
- u32 oldval;
+ u32 uninitialized_var(oldval);

/*
* There is no waiter, so we unlock the futex. The owner died
@@ -1546,7 +1546,7 @@ static int fixup_pi_state_owner(u32 __user *uaddr, struct futex_q *q,
u32 newtid = task_pid_vnr(newowner) | FUTEX_WAITERS;
struct futex_pi_state *pi_state = q->pi_state;
struct task_struct *oldowner = pi_state->owner;
- u32 uval, curval, newval;
+ u32 uval, uninitialized_var(curval), newval;
int ret;

/* Owner died? */
@@ -2451,7 +2451,7 @@ err_unlock:
*/
int handle_futex_death(u32 __user *uaddr, struct task_struct *curr, int pi)
{
- u32 uval, nval, mval;
+ u32 uval, uninitialized_var(nval), mval;

retry:
if (get_user(uval, uaddr))
--
1.7.4.1



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/