Re: [PATCH] x86: enable rtc-efi

[Matthew Garrett]

On Wed, Jul 06, 2011 at 08:09:45AM +0100, Jan Beulich wrote:
> >>> On 05.07.11 at 20:29, Matthew Garrett <mjg59@xxxxxxxxxxxxx> wrote:
> > You haven't removed this from the IA64 code. Isn't that going to result 
> > in registering the same device twice?
> 
> How would code under arch/ia64/ and code under arch/x86/ ever
> manage to register the same device twice?

Gah. Sorry, I misread and thought thsi was in the generic code too.

> >> +static int __init rtc_init(void)
> >> +{
> >> +	if (efi_enabled && platform_device_register(&rtc_efi_dev) < 0)
> >> +		printk(KERN_ERR "unable to register rtc device...\n");
> > 
> > Ought to -ENODEV if efi isn't present? The error message should also be 
> > more verbose.
> 
> I would agree on the -ENODEV part, but the error message is what
> the original ia64 code (which I simply copied over and modified
> slightly) has, so if a change is needed it ought to be done there first
> I would think. Additionally I can't really see what meaningful addition
> to the error message you envision.

EFI is the only way to access the rtc on IA64, whereas on x86 you'll 
almost certainly also have direct hardware access as well. Make it clear 
which rtc device you're unable to register.

-- 
Matthew Garrett | mjg59@xxxxxxxxxxxxx
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/