Re: backlight: aat2870_bl: questions about setting max_current

[Jinyoung Park]

Hi, Axel

> 1. Seems the implementation tests wrong value for setting 
aat2870_bl->max_current.
>     I think you mean:
Right, that's my mean. This is my mistyping bug.

> 2. Even above issue is fixed, you still cannot differentiate below 2 
cases:
>          a) if pdata->max_current is not set , or
>          b) pdata->max_current is set to AAT2870_CURRENT_0_45 ( which 
is also 0 ).
>     In either case, current implementation will set max_current to 
AAT2870_CURRENT_27_9.
I didn't find it when verifying driver on real device and my self review.
Thanks for your kindly review.

Below is fixed codes. How about this change?
If there is no problem, could you submit this change with first change 
as one patch?
because two changes are related.

diff --git a/drivers/video/backlight/aat2870_bl.c 
b/drivers/video/backlight/aat2870_bl.c
index 4952a61..c0e2ce7 100644
--- a/drivers/video/backlight/aat2870_bl.c
+++ b/drivers/video/backlight/aat2870_bl.c
@@ -44,7 +44,7 @@ static inline int aat2870_brightness(struct 
aat2870_bl_driver_data *aat2870_bl,
        struct backlight_device *bd = aat2870_bl->bd;
        int val;

-       val = brightness * aat2870_bl->max_current;
+       val = brightness * (aat2870_bl->max_current - 1);
        val /= bd->props.max_brightness;

        return val;
diff --git a/include/linux/mfd/aat2870.h b/include/linux/mfd/aat2870.h
index 89212df..f8b7e8e 100644
--- a/include/linux/mfd/aat2870.h
+++ b/include/linux/mfd/aat2870.h
@@ -89,6 +89,7 @@ enum aat2870_id {

 /* Backlight current magnitude (mA) */
 enum aat2870_current {
+       AAT2870_CURRENT_0_00,
        AAT2870_CURRENT_0_45,
        AAT2870_CURRENT_0_90,
        AAT2870_CURRENT_1_80,

Thanks,
Jin.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/