Re: [PATCH] x86: enable rtc-efi

[Matthew Garrett]

On Tue, Jul 05, 2011 at 08:38:51AM +0100, Jan Beulich wrote:
> Besides a Kconfig change this just requires creating a respective
> platform device.

Couple of other issues:

> +static struct platform_device rtc_efi_dev = {
> +	.name = "rtc-efi",
> +	.id = -1,
> +};

You haven't removed this from the IA64 code. Isn't that going to result 
in registering the same device twice?

> +static int __init rtc_init(void)
> +{
> +	if (efi_enabled && platform_device_register(&rtc_efi_dev) < 0)
> +		printk(KERN_ERR "unable to register rtc device...\n");

Ought to -ENODEV if efi isn't present? The error message should also be 
more verbose.

-- 
Matthew Garrett | mjg59@xxxxxxxxxxxxx
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/