Re: [patch 11/11] sparc/irqs: Do not trace arch_local_{*,irq_*}functions

From: Steven Rostedt
Date: Tue Jul 05 2011 - 08:49:15 EST


On Fri, 2011-07-01 at 21:11 -0700, David Miller wrote:
> From: Steven Rostedt <rostedt@xxxxxxxxxxx>
> Date: Fri, 01 Jul 2011 23:04:46 -0400
>
> > From: Steven Rostedt <srostedt@xxxxxxxxxx>
> >
> > Do not trace arch_local_save_flags(), arch_local_irq_*() and friends.
> > Although they are marked inline, gcc may still make a function out of
> > them and add it to the pool of functions that are traced by the function
> > tracer. This can cause undesirable results (kernel panic, triple faults,
> > etc).
> >
> > Add the notrace notation to prevent them from ever being traced.
> >
> > Cc: "David S. Miller" <davem@xxxxxxxxxxxxx>
> > Signed-off-by: Steven Rostedt <rostedt@xxxxxxxxxxx>
>
> Acked-by: David S. Miller <davem@xxxxxxxxxxxxx>

Thanks David!

Could you pull the patch into your tree. It's not dependent on any other
patch, so I feel more comfortable that it goes through yours than the
tracing tree.

Thanks,

-- Steve


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/