Re: Patch to add guarding parentheses to some macros in linux/input.h

[Dmitry Torokhov]

Hi Simon,

On Tue, Jun 07, 2011 at 12:51:12PM +0200, Simon Budig wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
> 
> On 06/01/2011 11:20 PM, Simon Budig wrote:
> > The attached patch adds parentheses to ensure correct operator precedence.
> 
> Seems this patch did not draw any attention to it. Is this because it is
> somewhat pointless? Or is it too uncontroversial?  :-)
> 
> I'd appreciate any hints on how to proceed from here.
> 

I do not believe that 'len' will give any trouble since there are no
computations done with this macro argument, but you are absolutely
correct that 'ev' and 'abs' should be protected in EVIOCGBIT and
EVIOC(G|S)ABS. I extracted the relevant changes from your patch and
queued for 3.1.

Thanks.

-- 
Dmitry
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/