Re: [patch] regulator/tps65912: storing error codes in u8

[Liam Girdwood]

On Thu, 2011-06-23 at 08:57 +0300, Dan Carpenter wrote:
> get_ctrl_reg() returns -EINVAL so the error handling won't work here
> if reg is a u8.
> 
> Signed-off-by: Dan Carpenter <error27@xxxxxxxxx>
> 
> diff --git a/drivers/regulator/tps65912-regulator.c b/drivers/regulator/tps65912-regulator.c
> index d2c6542..3a9313e 100644
> --- a/drivers/regulator/tps65912-regulator.c
> +++ b/drivers/regulator/tps65912-regulator.c
> @@ -417,7 +417,7 @@ static int tps65912_reg_enable(struct regulator_dev *dev)
>  	struct tps65912_reg *pmic = rdev_get_drvdata(dev);
>  	struct tps65912 *mfd = pmic->mfd;
>  	int id = rdev_get_id(dev);
> -	u8 reg;
> +	int reg;
>  
>  	if (id < TPS65912_REG_DCDC1 || id > TPS65912_REG_LDO10)
>  		return -EINVAL;

Samuel, would you mind taking this since tps65912 is upstreaming via
mfd.

Thanks !

Liam

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/