Re: module: sysfs - add 'uevent' file to allow coldplug

[Kay Sievers]

On Mon, Jul 4, 2011 at 07:05, Rusty Russell <rusty@xxxxxxxxxxxxxxx> wrote:
> On Fri, 1 Jul 2011 05:07:41 +0200, Kay Sievers <kay.sievers@xxxxxxxx> wrote:
>> On Thu, Jun 23, 2011 at 13:24, Kay Sievers <kay.sievers@xxxxxxxx> wrote:
>> > On Thu, Jun 23, 2011 at 02:27, Rusty Russell <rusty@xxxxxxxxxxxxxxx> wrote:
>> >> On Wed, 22 Jun 2011 12:17:49 +0200, Kay Sievers <kay.sievers@xxxxxxxx> wrote:
>> >>> On Wed, Jun 22, 2011 at 04:00, Rusty Russell <rusty@xxxxxxxxxxxxxxx> wrote:
>> >> I'd prefer that patch first, I think: it's a sensible cleanup.
>> >
>> > You want the patch split up in two? You want to remove the mod
>> > parameter somehow?
>>
>> Can we get these 20 lines of code sorted out please? :)
>
> An odd question, since I was waiting for you to do exactly that!

Oh, I was just waiting for your answer to the earlier question 6 lines
above here. :)

> Rather than go around again, I have:
> 1) Split the patch into one which changes the attr functions, and one
> Â which adds the uevent file.
> 2) Fixed the title of the (second) patch to "module: add
> Â /sys/module/<name>/uevent files"
> 3) Fixed up the three checkpatch.pl errors (sure, 2 were just code
> Â moves, but we're slowly neatening things).
>
> Here they are below, back-to-back.

Great. Thanks a lot for doing this.

Kay
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/