Re: Re: [PATCH v6 08/18] mfd: twl6040: Add initial support

[Péter Ujfalusi]

Hi Samuel,

On Monday 04 July 2011 13:48:44 Samuel Ortiz wrote:
> Hi Peter,
> 
> On Tue, Jun 21, 2011 at 04:39:06PM +0300, Peter Ujfalusi wrote:
> > +int twl6040_is_powered(struct twl6040 *twl6040)
> > +{
> > +	return twl6040->power_count;
> > +}
> > +EXPORT_SYMBOL(twl6040_is_powered);
> 
> Do we really need to export this one ?

No, we don't.
At the end we do not need this function at all either.
I'm going to remove it.
 
> > +static inline int twl6040_get_rev(struct twl6040 *twl6040)
> > +{
> > +	return twl6040->rev;
> > +}

No need for this either, I'll remove it.

> > +
> > +static inline int twl6040_request_irq(struct twl6040 *twl6040, int irq,
> > +				      irq_handler_t handler,
> > +				      unsigned long irqflags,
> > +				      const char *name,
> > +				      void *data)
> > +{
> > +	if (!twl6040->irq_base)
> > +		return -EINVAL;
> > +
> > +	return request_threaded_irq(twl6040->irq_base + irq, NULL, handler,
> > +				    irqflags, name, data);
> > +}
> > +
> > +static inline void twl6040_free_irq(struct twl6040 *twl6040, int irq,
> > +				    void *data)
> > +{
> > +	if (!twl6040->irq_base)
> > +		return;
> > +
> > +	free_irq(twl6040->irq_base + irq, data);
> > +}
> 
> I don't see the value of those 3 inline functions. Removing them would make
> the code actually more understandable (especially for the 2nd one).

The twl6040_request_irq is also used by the ASoC codec driver, and the vibra 
driver, but if you think it is better to replace those as well, I will do it 
right away.

-- 
Péter
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/