Re: [PATCH 1/4] perf: Add memory load/store events generic code

From: Peter Zijlstra
Date: Mon Jul 04 2011 - 07:16:57 EST


On Mon, 2011-07-04 at 08:02 +0000, Lin Ming wrote:
> +#define MEM_STORE_DCU_HIT (1ULL << 0)

I'm pretty sure that's not Dublin City University, but what is it?
Data-Cache-Unit? what does that mean, L1/L2 or also L3?

> +#define MEM_STORE_STLB_HIT (1ULL << 1)

What's an sTLB? I know iTLB and dTLB's but sTLBs I've not heard of yet.

> +#define MEM_STORE_LOCKED_ACCESS (1ULL << 2)

Presumably that's about LOCK'ed ops?

So now you're just tacking bits on the end without even attempting to
generalize/unify things, not charmed at all.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/