Re: [PATCH 5/6] x86: Remove useless unwinder backlink from irq regssaving

[Ingo Molnar]

* Jan Beulich <JBeulich@xxxxxxxxxx> wrote:

> >>> On 02.07.11 at 18:29, Frederic Weisbecker <fweisbec@xxxxxxxxx> wrote:
> > The unwinder backlink in interrupt entry is very useless.
> > It's actually not part of the stack frame chain and thus is
> > never used.
> 
> I very much doubt this - see dump_trace()'s comment in its IRQ-stack
> related code portion (and the corresponding use of irq_stack_end[-1]).

> > +++ b/arch/x86/kernel/entry_64.S
> > @@ -327,7 +327,6 @@ ENDPROC(native_usergs_sysret64)
> >  	jne 2f
> >  	mov PER_CPU_VAR(irq_stack_ptr),%rsp
> >  	EMPTY_FRAME 0
> > -	pushq_cfi %rbp			/* backlink for unwinder */
> >  	/*
> >  	 * We entered an interrupt context - irqs are off:
> >  	 */

Frederic, please add it back with a much better comment in the .S 
showing where it's used and how. Perhaps even try to trigger the 
usage of this backlink and document the effect in the changelog.

Thanks,

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/