Re: [PATCH] mfd: remove dead code fromdrivers/mfd/max8997-irq.c:get_i2c()

From: MyungJoo Ham
Date: Sun Jul 03 2011 - 21:17:05 EST


Sender : Jesper Juhl<jj@xxxxxxxxxxxxx> Date : 2011-07-03 05:38 (GMT+09:00)
>
> We either hit one of the case's or the default in the switch statement
> in get_i2c(), so the 'return ERR_PTR(-EINVAL);' at the end of the
> function is just dead code - remove it.
>
> Signed-off-by: Jesper Juhl

Looks good.

Acked-by: MyungJoo Ham <myungjoo.ham@xxxxxxxxxxx>

> ---
> drivers/mfd/max8997-irq.c | 2 --
> 1 files changed, 0 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/mfd/max8997-irq.c b/drivers/mfd/max8997-irq.c
> index 638bf7e..09274cf 100644
> --- a/drivers/mfd/max8997-irq.c
> +++ b/drivers/mfd/max8997-irq.c
> @@ -58,8 +58,6 @@ static struct i2c_client *get_i2c(struct max8997_dev *max8997,
> default:
> return ERR_PTR(-EINVAL);
> }
> -
> - return ERR_PTR(-EINVAL);
> }
>
> struct max8997_irq_data {
> --
> 1.7.6
>
>
> --
> Jesper Juhl http://www.chaosbits.net/
> Don't top-post http://www.catb.org/jargon/html/T/top-post.html
> Plain text mails only, please.

MyungJoo Ham (함명주)
Mobile Software Platform Lab,
Digital Media and Communications (DMC) Business
Samsung Electronics
cell: +82-10-6714-2858 / office: +82-31-279-8033?移»®&Þ~º&¶¬–+-깁負¥Šw®왢쎉喝méb욎dz받–)í끾èw*jgП¨¶‰šŽ듶¢j/곴äz받–듺2듷솳鈺Ú&¢)傘«a뛴®G«앶h®æj:+v돣Šwè녪¥>W슧違iÛaxPjØm¶Ÿÿà -»+껠dš_