Re: [PATCH 1/1] mmap: Don't count shmem pages as free in __vm_enough_memory

From: Minchan Kim
Date: Sun Jul 03 2011 - 20:43:20 EST


On Mon, Jul 4, 2011 at 4:39 AM, Dmitry Fink <finikk@xxxxxxxxx> wrote:
> shmem pages can't be reclaimed and if they are swapped out
> that doesn't affect the overall available memory in the system,
> so don't count them along with the rest of the file backed pages.
>
> Signed-off-by: Dmitry Fink <dmitry.fink@xxxxxxxx>
Reviewed-by: Minchan Kim <minchan.kim@xxxxxxxxx>

I am not sure the description is good. :(
But I think this patch is reasonable.

In swapless system,guessing overcommit can have a problem.
And in current implementation of OVERCOMMIT_GUESS, we consider anon
pages as empty space of swap so shmem pages should be accounted by
that.

--
Kind regards,
Minchan Kim
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/