Re: [PATCH 09/11] dynamic_debug: add_to_pending() saves non-matchingqueries for later.

From: Bart Van Assche
Date: Sun Jul 03 2011 - 04:27:38 EST


On Tue, Jun 28, 2011 at 4:48 PM, Jason Baron <jbaron@xxxxxxxxxx> wrote:
> A number of ppl have expressed interest to me in this functionality...
>
> I'm wondering if we should call out this usage explicitly with a new
> flag like '+a'. Meaning 'add' as a pending query if it doesn't match
> anything existing.
>
> In this way, we can have error when things don't match in the normal case.
> Otherwise, somebody might think they've enabled something when they've in fact
> added a pending query.

That suggestion makes sense to me - I think it's better that the user
makes it explicit whether or not a query should be added to the
pending list instead of the ddebug code trying to find out which list
a query should be added to.

Bart.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/