Re: [PATCH 0/11] dynamic_debug: allow multiple pending queries on boot-line

From: Bart Van Assche
Date: Sun Jul 03 2011 - 04:20:38 EST


On Tue, Jun 28, 2011 at 9:09 AM, Jim Cromie <jim.cromie@xxxxxxxxx> wrote:
> This patchset extends dynamic-debug facility to allow
> use of pr_debug() within a loadable module's module_init()
> function.

Can you please clean up checkpatch complaints before resubmitting ?
This is what checkpatch reports on the current patch set:

ERROR: code indent should use tabs where possible
#125: FILE: lib/dynamic_debug.c:119:
+ sprintf(prbuf_query,$

WARNING: please, no spaces at the start of a line
#125: FILE: lib/dynamic_debug.c:119:
+ sprintf(prbuf_query,$

ERROR: code indent should use tabs where possible
#211: FILE: lib/dynamic_debug.c:357:
+ sprintf(prbuf_query,$

WARNING: please, no spaces at the start of a line
#211: FILE: lib/dynamic_debug.c:357:
+ sprintf(prbuf_query,$

ERROR: trailing whitespace
#442: FILE: lib/dynamic_debug.c:756:
+^I^I^I$

ERROR: trailing whitespace
#469: FILE: lib/dynamic_debug.c:813:
+^I^I$

ERROR: else should follow close brace '}'
#483: FILE: lib/dynamic_debug.c:827:
+ }
+ else if (verbose)

Thanks,

Bart.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/