Re: [PATCH v2] kernel: escape non-ASCII and control characters inprintk()

From: Greg KH
Date: Sat Jul 02 2011 - 11:16:37 EST


On Sat, Jul 02, 2011 at 12:10:22PM +0400, Vasiliy Kulikov wrote:
> Greg - do you know any devices supplying multibyte strings, but not in
> UTF-8 encoding? If yes, then CSI filtering is a bad idea :\

USB is "supposed" to have UTF-16 strings, but there's devices out there
that have crazy stuff in them. And of course, anyone can put anything
in the device string if they know how to write a bit of firmware, so we
have to watch out for that. Hopefully we handle that properly in the
usb_string() function in the kernel but review of it is always nice to
have.

Other than that, I don't know of any multi-byte strings in devices at
the moment. I haven't seen the Thunderbolt specs though, so who knows
what is coming next.

Hope this helps,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/