Re: [PATCH RFC 1/2 ] [x86] Modify comments and clean up code.

From: Ingo Molnar
Date: Fri Jul 01 2011 - 16:21:55 EST



* Andi Kleen <andi@xxxxxxxxxxxxxx> wrote:

> ling.ma@xxxxxxxxx writes:
>
> > From: Ma Ling <ling.ma@xxxxxxxxx>
> >
> > Modern CPU use fast-string instruction to accelerate copy performance,
> > by combining data into 128bit, so we modify comments and code style.
>
> The description has nothing to do with the patch.
>
> As far as I can tell the patch just renames one symbol
> and changes all white space. Not fully sure what the point of it
> is.
>
> But normally white space change patches are not supposed to have
> any other changes because the other changes embedded in them are
> impossible to review.

Non-functional cleanups can go into the same patch as whitespace
cleanups, as long as the generated object code does not change.

Thanks,

Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/