Re: [PATCHv2] kconfig: introduce specialized printer

From: Michal Marek
Date: Fri Jul 01 2011 - 10:51:23 EST


On 9.6.2011 15:01, Michal Marek wrote:
On Sun, May 15, 2011 at 11:42:09PM -0400, Arnaud Lacombe wrote:
Make conf_write_symbol() grammar agnostic to be able to use it from different
code path. These path pass a printer callback which will print a symbol's name
and its value in different format.

conf_write_symbol()'s job become mostly only to prepare a string for the
printer. This avoid to have to pass specialized flag to generic
functions

Signed-off-by: Arnaud Lacombe<lacombar@xxxxxxxxx>
---
scripts/kconfig/confdata.c | 268 +++++++++++++++++++++++++++----------------
scripts/kconfig/lkc.h | 5 +
scripts/kconfig/lkc_proto.h | 1 +
scripts/kconfig/symbol.c | 46 +++++++-
4 files changed, 219 insertions(+), 101 deletions(-)

History:
v2: Address Michal's comment in msg-id<4D10D7DF.7040903@xxxxxxx>:
- add brief comment before each printer
- introduce a `skip_unset' variable in kconfig printer
- merge inner switch in an if() statement
- annotate fallthrough
- fix tristate printer behavior

Hi,

below is my merge with current kbuild-2.6.git#kconfig, notably with the
config_is_xxx() stuff (which we should finalize somehow, but that's not
the point here). Please review, thanks.


Subject: [PATCH] kconfig: introduce specialized printer

Rebase of Arnaud's patch on top of "kconfig: autogenerated config_is_xxx
macro".

Pushed to kbuild-2.6.git#kconfig.

Michal
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/