Re: [PATCH 0/2] netpoll: Trivial updates

From: Cong Wang
Date: Fri Jul 01 2011 - 00:00:31 EST


ä 2011å07æ01æ 11:55, Joe Perches åé:
On Fri, 2011-07-01 at 11:49 +0800, Cong Wang wrote:
ä 2011å07æ01æ 11:35, Joe Perches åé:
BTW, you can kill the export of netpoll_send_skb_on_dev() too.
Not too sure about that.
It's used in netpoll.h by netpoll_send_skb.
It could be called from anywhere.
It's currently called/used by bonding.h.
% git grep netpoll_send_skb_on_dev .
include/linux/netpoll.h:void netpoll_send_skb_on_dev(struct netpoll *np, struct sk_buff *skb,
include/linux/netpoll.h: netpoll_send_skb_on_dev(np, skb, np->dev);
net/core/netpoll.c:void netpoll_send_skb_on_dev(struct netpoll *np, struct sk_buff *skb,
net/core/netpoll.c:EXPORT_SYMBOL(netpoll_send_skb_on_dev);
No modules use it...

Read what I wrote.

Look up one level at where it's used by netpoll.h.


Then move netpoll_send_skb(), export it instead of netpoll_send_skb_on_dev()...
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/